[#774] Restructure storyline deadline + stats into 2-col grid#780
[#774] Restructure storyline deadline + stats into 2-col grid#780realproject7 merged 3 commits intomainfrom
Conversation
- Market Cap and Supply Minted in a 2-column bordered grid - Deadline countdown in a full-width bordered box below with "Next Plot Publish Deadline" label - Story complete box also moved into the same layout section - All boxes stack vertically on mobile via space-y-2 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Clean restructure:
- Market Cap + Supply Minted in 2-col grid (unchanged content)
- Deadline moved to full-width bordered box below with "Next Plot Publish Deadline" label
- Sunset state also gets consistent bordered box styling
- Both deadline and sunset correctly gated behind
priceInfocheck now (moved inside the conditional), which makes sense since they're part of the header stats section - Mobile stacks naturally via
space-y-2
No concerns.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The bordered deadline box direction is right, but the current implementation misses the mobile layout requirement and leaves a duplicated countdown label inside the new section.
Findings
- [medium] The stats row is still hard-coded to
grid-cols-2, so on mobile the Market Cap and Supply boxes remain side by side instead of stacking vertically as the ticket requires. The issue explicitly calls for mobile to stack all boxes vertically.- File:
src/app/story/[storylineId]/page.tsx:294 - Suggestion: Use a responsive grid such as
grid-cols-1 sm:grid-cols-2for the stats boxes.
- File:
- [low] The new wrapper adds a
Next Plot Publish Deadlineheading, butDeadlineCountdownstill renders its ownDeadline:label inside the box, so the UI reads like a duplicated title rather than a clean single labeled section.- File:
src/app/story/[storylineId]/page.tsx:318 - File:
src/components/DeadlineCountdown.tsx:23 - Suggestion: Either add a label-less mode to
DeadlineCountdownfor this use, or render only the countdown value inside the new bordered section.
- File:
Decision
Requesting changes because the current layout does not satisfy the mobile stacking acceptance criteria, and the deadline box copy is still redundant.
…e label 1. Grid changed to grid-cols-1 sm:grid-cols-2 so boxes stack on mobile 2. Added hideLabel prop to DeadlineCountdown to avoid redundant "Deadline:" text when the parent box already has a heading Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The mobile grid layout issue is fixed. The new hideLabel prop only handles the loading and expired states, so the active countdown still renders redundant Deadline: text under the new heading.
Findings
- [medium]
hideLabelis not applied in the normal countdown render path, so the storyline page still showsNext Plot Publish Deadlinefollowed byDeadline: 6d ...for active deadlines.- File:
src/components/DeadlineCountdown.tsx:52 - Suggestion: Apply the same
hideLabelguard in the final return branch so all countdown states render label-free when embedded under the new heading.
- File:
Decision
Requesting changes because the PR still leaves the duplicate deadline label in the common non-expired state, so the UI issue from #774 is only partially fixed.
The replace_all missed the third render branch (active countdown). Now all three states (null, expired, active) respect hideLabel. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR now fully matches issue #774. The stats boxes stack on mobile, and the embedded deadline countdown no longer duplicates the label under the new heading.
Findings
- None.
Decision
Approving because the remaining deadline-label issue is fixed and the change stays focused on the requested layout restructure.
Summary
space-y-2Fixes #774
Test plan
npm run buildpasses🤖 Generated with Claude Code